Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --checkpoint-sync-url flag instead of initial state #13

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

pablomendezroyo
Copy link
Contributor

Use --checkpoint-sync-url flag instead of initial state

@Marketen
Copy link
Contributor

Marketen commented Nov 5, 2024

removed eth/v2/debug/beacon/states/ from entrypoint.

when using --checkpoint-sync-url, we dont need do append eth/v2/debug/beacon/states/, since teku already does. result is that the checkpoint sync url is appended eth/v2/debug/beacon/states/ two times as shown in error:

2024-11-05 01:19:26.836 FATAL - Failed to load initial state from https://checkpoint-sync-holesky.dappnode.io/eth/v2/debug/beacon/states/eth/v2/debug/beacon/states/genesis

@Marketen
Copy link
Contributor

Marketen commented Nov 5, 2024

This PR changes how a checkpoint sync is loaded, it doesnt solve the weak subjectivity point issue. When a db is initialized, teku will ignore syncing from checkpoint and try to continue from the latest slot synced in db.

Fix would be letting teku sync from outside weak subjectivity point, but its not safe practices: #14

@Marketen Marketen merged commit 7769b48 into main Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants